fix: workspace permission entire update

Signed-off-by: Lin Wang <[email protected]>

src/plugins/workspace/server/utils.test.ts

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import { generateRandomId } from './utils';
+import { generateRandomId, convertToFullPermissions } from './utils';
 
 describe('workspace utils', () => {
   it('should generate id with the specified size', () => {
@@ -19,3 +19,38 @@ describe('workspace utils', () => {
     expect(ids.size).toBe(NUM_OF_ID);
   });
 });
+
+describe('convertToFullPermissions', () => {
+  it('should convert partial permissions to full permissions', () => {
+    // Arrange
+    const partialPermissions = {
+      read: { users: ['user1'], groups: ['group1'] },
+      write: { users: ['user2'] },
+      management: { groups: ['group1'] },
+    };
+
+    const expectedFullPermissions = {
+      read: { users: ['user1'], groups: ['group1'] },
+      write: { users: ['user2'], groups: [] },
+      management: { users: [], groups: ['group1'] },
+      library_read: { users: [], groups: [] },
+      library_write: { users: [], groups: [] },
+    };
+
+    expect(convertToFullPermissions(partialPermissions)).toEqual(expectedFullPermissions);
+  });
+
+  it('should handle empty partial permissions', () => {
+    const partialPermissions = {};
+
+    const expectedFullPermissions = {
+      read: { users: [], groups: [] },
+      write: { users: [], groups: [] },
+      management: { users: [], groups: [] },
+      library_read: { users: [], groups: [] },
+      library_write: { users: [], groups: [] },
+    };
+
+    expect(convertToFullPermissions(partialPermissions)).toEqual(expectedFullPermissions);
+  });
+});

src/plugins/workspace/server/utils.ts

@@ -4,10 +4,33 @@
  */
 
 import crypto from 'crypto';
+import type { Permissions } from '../../../core/server';
+import { WorkspacePermissionMode } from '../../../core/server';
 
 /**
  * Generate URL friendly random ID
  */
 export const generateRandomId = (size: number) => {
   return crypto.randomBytes(size).toString('base64url').slice(0, size);
 };
+
+const addMissingPrincipals = (principals: Permissions[string]) => ({
+  users: principals.users || [],
+  groups: principals.groups || [],
+});
+
+/**
+ * Converts a partial permissions object to a full permissions object by adding missing principals for each permission mode.
+ * @param permissions - The partial permissions object.
+ * @returns The full permissions object with all permission modes and their corresponding principals.
+ */
+export const convertToFullPermissions = (permissions: Permissions) => ({
+  ...permissions,
+  ...Object.values(WorkspacePermissionMode).reduce(
+    (previousValue, permissionMode) => ({
+      ...previousValue,
+      [permissionMode]: addMissingPrincipals(permissions[permissionMode] || {}),
+    }),
+    {}
+  ),
+});

src/plugins/workspace/server/workspace_client.ts

@@ -19,7 +19,7 @@ import {
   WorkspaceAttributeWithPermission,
 } from './types';
 import { workspace } from './saved_objects';
-import { generateRandomId } from './utils';
+import { generateRandomId, convertToFullPermissions } from './utils';
 
 const WORKSPACE_ID_SIZE = 6;
 
@@ -167,7 +167,7 @@ export class WorkspaceClientWithSavedObject implements IWorkspaceDBImpl {
         }
       }
       await client.update<Omit<WorkspaceAttribute, 'id'>>(WORKSPACE_TYPE, id, attributes, {
-        permissions,
+        permissions: convertToFullPermissions(permissions),
       });
       return {
         success: true,