Rename index_pattern_management plugin (#37) #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bishoy Boktor <[email protected]>
mihirsoni
reviewed
Mar 10, 2021
..._pattern_management/public/components/create_index_pattern_wizard/lib/get_matched_indices.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Bishoy Boktor <[email protected]>
kavilla
previously requested changes
Mar 11, 2021
...ttern_wizard/components/step_index_pattern/components/status_message/status_message.test.tsx
Show resolved
Hide resolved
...onents/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.test.tsx
Outdated
Show resolved
Hide resolved
...onents/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.test.tsx
Outdated
Show resolved
Hide resolved
...onents/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.test.tsx
Show resolved
Hide resolved
Signed-off-by: Bishoy Boktor <[email protected]>
kavilla
approved these changes
Mar 12, 2021
|
We can note the logic needs to change and work on it during build phase |
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
* Rename index_pattern_management plugin (#37) Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
* Rename index_pattern_management plugin (#37) Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]>
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
* Rename index_pattern_management plugin (#37) Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]> * Address PR comments Signed-off-by: Bishoy Boktor <[email protected]>
gaobinlong
pushed a commit
to gaobinlong/OpenSearch-Dashboards
that referenced
this pull request
Sep 11, 2023
* fix: workspace permission entire update Signed-off-by: Lin Wang <[email protected]> * refactor: rename to convertToFullWorkspacePermissions and remove read and write permission Signed-off-by: Lin Wang <[email protected]> * Revert "refactor: rename to convertToFullWorkspacePermissions and remove read and write permission" This reverts commit a4b7ba7. Signed-off-by: Lin Wang <[email protected]> * Revert "fix: workspace permission entire update" This reverts commit d972e13. Signed-off-by: Lin Wang <[email protected]> * fix: update to client.create to override entire object Signed-off-by: Lin Wang <[email protected]> * feat: add workspace version limit for object update Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2023
…nsearch-project#141) * fix: workspace permission entire update * refactor: rename to convertToFullWorkspacePermissions and remove read and write permission * Revert "refactor: rename to convertToFullWorkspacePermissions and remove read and write permission" This reverts commit a4b7ba7. * Revert "fix: workspace permission entire update" This reverts commit d972e13. * fix: update to client.create to override entire object * feat: add workspace version limit for object update --------- (cherry picked from commit 0bd03df) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 15, 2023
* fix: workspace permission entire update Signed-off-by: Lin Wang <[email protected]> * refactor: rename to convertToFullWorkspacePermissions and remove read and write permission Signed-off-by: Lin Wang <[email protected]> * Revert "refactor: rename to convertToFullWorkspacePermissions and remove read and write permission" This reverts commit a4b7ba7. Signed-off-by: Lin Wang <[email protected]> * Revert "fix: workspace permission entire update" This reverts commit d972e13. Signed-off-by: Lin Wang <[email protected]> * fix: update to client.create to override entire object Signed-off-by: Lin Wang <[email protected]> * feat: add workspace version limit for object update Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bishoy Boktor [email protected]