fix: workspace permission entire update (opensearch-project#132)

* fix: workspace permission entire update Signed-off-by: Lin Wang <[email protected]> * refactor: rename to convertToFullWorkspacePermissions and remove read and write permission Signed-off-by: Lin Wang <[email protected]> * Revert "refactor: rename to convertToFullWorkspacePermissions and remove read and write permission" This reverts commit a4b7ba7. Signed-off-by: Lin Wang <[email protected]> * Revert "fix: workspace permission entire update" This reverts commit d972e13. Signed-off-by: Lin Wang <[email protected]> * fix: update to client.create to override entire object Signed-off-by: Lin Wang <[email protected]> * feat: add workspace version limit for object update Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]>
SuZhou-Joe · Sep 11, 2023 · 0bd03df · 0bd03df
1 parent 18300f0
commit 0bd03df
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/plugins/workspace/server/workspace_client.ts b/src/plugins/workspace/server/workspace_client.ts
@@ -166,9 +166,14 @@ export class WorkspaceClientWithSavedObject implements IWorkspaceDBImpl {
           throw new Error(DUPLICATE_WORKSPACE_NAME_ERROR);
         }
       }
-      await client.update<Omit<WorkspaceAttribute, 'id'>>(WORKSPACE_TYPE, id, attributes, {
+
+      await client.create<Omit<WorkspaceAttribute, 'id'>>(WORKSPACE_TYPE, attributes, {
+        id,
         permissions,
+        overwrite: true,
+        version: workspaceInDB.version,
       });
+
       return {
         success: true,
         result: true,