[Tests] update disable bucket agg feature for tests #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
previously approved these changes
Feb 26, 2022
|
Why did the tests not fail in the PR? |
It was missed. If you would like we can revert the PR instead. |
kavilla
force-pushed
the
avillk/bucketaggconfigtests
branch
from
9a0f071 to
2a98ec1
Compare
Test failure introduced: opensearch-project#1196 Updating to handle the if that configuration is not found or if it is not an array. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
avillk/bucketaggconfigtests
branch
from
2a98ec1 to
316f2ec
Compare
tmarkley
approved these changes
Feb 26, 2022
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Mar 3, 2022
…ct#1284) Test failure introduced: opensearch-project#1196 Updating to handle the if that configuration is not found or if it is not an array. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
7 tasks
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Mar 3, 2022
…ct#1284) Test failure introduced: opensearch-project#1196 Updating to handle the if that configuration is not found or if it is not an array. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
kavilla
added a commit
that referenced
this pull request
Mar 7, 2022
…#1196) (#1309) * Add option to configure available bucket agg types + jest tests (#1196) * Add option to configure available bucket agg types + jest tests * Change key to disableBucketAgg * Rephrase * made description clearer, csv clarification Signed-off-by: Royi Sitbon <[email protected]> * [Tests] update disable bucket agg feature for tests (#1284) Test failure introduced: #1196 Updating to handle the if that configuration is not found or if it is not an array. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: Royi Sitbon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test failure introduced:
#1196
Updating to handle the if that configuration is not found or if it is
not an array.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
n/a
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr