Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] any type if possible #1291

Open
kavilla opened this issue Feb 26, 2022 · 0 comments
Open

[Cleanup] any type if possible #1291

kavilla opened this issue Feb 26, 2022 · 0 comments
Labels
technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@kavilla
Copy link
Member

kavilla commented Feb 26, 2022

Describe the bug

During the Node upgrade, we began to start seeing linter complaints about types being implicitly typed as any. To get around that we explicitly typed them as any. However some files were missed when updated to explicitly typed:

For example:

To Reproduce
Navigate to those files, notice the linter complain.

Expected behavior
The solution to type as any was a temp fix we should explicitly type it as the expected type if possible.

@kavilla kavilla added bug Something isn't working untriaged and removed bug Something isn't working labels Feb 26, 2022
@kavilla kavilla changed the title [Refactor] any type if possible [Cleanup] any type if possible Feb 26, 2022
@kavilla kavilla removed the untriaged label Feb 26, 2022
@tmarkley tmarkley added the technical debt If not paid, jeapardizes long-term success and maintainability of the repository. label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
None yet
Development

No branches or pull requests

2 participants