Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Add option to configure available bucket agg types + jest tests (#1196) #1309

Merged

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 3, 2022

Description

Add option to configure available bucket agg types + jest tests

  • Change key to disableBucketAgg
  • Rephrase
  • made description clearer, csv clarification
  • update disable bucket agg feature for tests

Backport PR:
#1196
#1284

Signed-off-by: sitbubu [email protected]

Issues Resolved

#1195

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@kavilla kavilla requested review from ananzh and tmarkley March 3, 2022 04:58
@kavilla kavilla added the v1.3.0 label Mar 3, 2022
RoyiSitbon and others added 2 commits March 3, 2022 05:03
…search-project#1196)

* Add option to configure available bucket agg types + jest tests
* Change key to disableBucketAgg
* Rephrase
* made description clearer, csv clarification

Signed-off-by: Royi Sitbon <[email protected]>
…ct#1284)

Test failure introduced:
opensearch-project#1196

Updating to handle the if that configuration is not found or if it is
not an array.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla force-pushed the avillk/1.x/disablebucketaggconfig branch from d05afde to 4106930 Compare March 3, 2022 05:04
@kavilla
Copy link
Member Author

kavilla commented Mar 4, 2022

Failures due to checksum conditional.

@kavilla kavilla merged commit d6a84ac into opensearch-project:1.x Mar 7, 2022
@kavilla kavilla deleted the avillk/1.x/disablebucketaggconfig branch March 7, 2022 22:37
@ashwin-pc ashwin-pc changed the title [1.x] Add option to configure available bucket agg types + jest tests (#1196) [Backport 1.x] Add option to configure available bucket agg types + jest tests (#1196) Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants