Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bucket aggregation types configurable #1195

Closed
RoyiSitbon opened this issue Feb 1, 2022 · 2 comments · Fixed by #1196
Closed

Make bucket aggregation types configurable #1195

RoyiSitbon opened this issue Feb 1, 2022 · 2 comments · Fixed by #1196
Labels
enhancement New feature or request

Comments

@RoyiSitbon
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We don't have an option to remove bucket aggregation types by demand. e.g. we want to disable the option of choosing ‘significant_terms’ bucket aggregation because it can be very heavy when run on large indices.

Describe the solution you'd like
We wish to add a configuration in order to disable nonrelevant bucket aggregation types. i.e by setting configuration as so, we will disable the option of choosing significant_terms aggregation:
significantTerm1

significantTerm2

Conversely, if the value will be an empty array, we could choose all options from the list:
significantTerm3

@kgcreative
Copy link
Member

Hey @RoyiSitbon - Would i be accurate in saying there's a desire to add some configurability and granularity to some of these features? I'm a little hesitant to suggest continuing to add .yaml settings to additional features in perpetuity, and have started thinking about how we might give some more granular controls to admins or even cluster admins in the future. Can you think of some additional use cases for these type of configuration changes?

@RoyiSitbon
Copy link
Contributor Author

Hey @kgcreative, thanks for replying.
We have several ideas for configuration changes. Some of them already opened as other issues/PRs.
e.g. #1178 was implemented for our needs of limiting bucket split rows. I guess it can be enriched with other agg types etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants