[Tests] update disable bucket agg feature for tests (#1284)

Test failure introduced: #1196 Updating to handle the if that configuration is not found or if it is not an array. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
opensearch-project · Feb 26, 2022 · 8ba11e3 · 8ba11e3
1 parent 749c858
commit 8ba11e3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/plugins/data/common/search/aggs/agg_types_registry.ts b/src/plugins/data/common/search/aggs/agg_types_registry.ts
@@ -91,8 +91,10 @@ export class AggTypesRegistry {
   start = ({ uiSettings }: AggTypesRegistryStartDependencies) => {
     const disabledBucketAgg = uiSettings.get('visualize:disableBucketAgg');
 
-    for (const k of this.bucketAggs.keys()) {
-      if (disabledBucketAgg.includes(k)) this.bucketAggs.delete(k);
+    if (disabledBucketAgg !== undefined && Array.isArray(disabledBucketAgg)) {
+      for (const k of this.bucketAggs.keys()) {
+        if (disabledBucketAgg.includes(k)) this.bucketAggs.delete(k);
+      }
     }
 
     return {

diff --git a/src/plugins/data/server/search/aggs/aggs_service.ts b/src/plugins/data/server/search/aggs/aggs_service.ts
@@ -32,11 +32,7 @@
 
 import { pick } from 'lodash';
 
-import {
-  UiSettingsServiceSetup,
-  UiSettingsServiceStart,
-  SavedObjectsClientContract,
-} from 'src/core/server';
+import { UiSettingsServiceStart, SavedObjectsClientContract } from 'src/core/server';
 import { ExpressionsServiceSetup } from 'src/plugins/expressions/common';
 import {
   AggsCommonService,
@@ -52,7 +48,6 @@ import { AggsSetup, AggsStart } from './types';
 /** @internal */
 export interface AggsSetupDependencies {
   registerFunction: ExpressionsServiceSetup['registerFunction'];
-  uiSettings: UiSettingsServiceSetup;
 }
 
 /** @internal */