-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: gcamfaostat: An R package to prepare, process, and synthesize FAOSTAT data for global agroeconomic and multisector dynamic modeling #6388
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @klau506Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @HenriKajasiltaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Dear @hugoledoux and @realxinzhao, This is an interesting contribution with the potential to be a broadly useful resource and source of documentation. I have read the manuscript and the documentation, installed the software and examined its code; see specific suggestions about both referenced above. Broadly:
I hope this is useful! I appreciate that the authors have done a lot of work, and am happy to clarify/answer questions if useful. Best, |
Hi @hugoledoux and @realxinzhao, I have installed the I have proposed fixes and suggestions that would improve the usability of the package and help it to meet the JOSS criteria. The resulting issues are here: #10 and #11 Please, let me know if you want me to clarify some of the comments or if I have misunderstood something in the package. I will be happy to take another look at the functionality once the fixes have been made! Br, |
Thank you so much, @klau506 and @HenriKajasilta for the careful reading of the paper and reviewing of the package, and the very helpful comments and suggestions! We will carefully address them and keep you posted. |
@editorialbot generate pdf |
@editorialbot commands |
Hello @realxinzhao, here are the things you can ask me to do:
|
@editorialbot check repository |
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
Dear @hugoledoux, @klau506 and @hugoledoux, We have now completed the revision of the paper and the package. Thank you for the careful reading of our paper and package. All the comments are very clear, spot-on, and useful! We believe the paper & package have been significantly improved as a result of the very useful comments and suggestions. The detailed point-by-point point responses are provided below in the issues suggested below: Manuscript Suggestions #7 Please let us know if you have more comments and suggestions or if we can provide additional information. Sincerely, |
@editorialbot generate pdf |
Thank you so much, @kthyng!!
|
@realxinzhao I didn't look through all references but at least looks like "R" isn't capitalized yet. |
@editorialbot generate pdf |
@kthyng Thank you so much! These are fixed now in the references. Sorry about the inconvenience (also good to learn the tricks). |
Ok good @realxinzhao! That R is capitalized, though I see a number of other proper nouns in references that should still be capitalized. |
@editorialbot generate pdf |
Oops... yes! @kthyng |
Ok then we are ready to go! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @realxinzhao! Many thanks to editor @hugoledoux and reviewers @klau506 and @HenriKajasilta for your time, hard work, and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@realxinzhao If you'd like to sign up as a reviewer, you can do so here: https://reviewers.joss.theoj.org/. |
Thank you all so much, All! This experience of leading a software publication as an economist/human-earth system modeler has been incredibly rewarding. I've learned a tremendous amount from the process, and I deeply appreciate the time and effort you've dedicated to enhancing both the software and the paper. Best regards, |
Submitting author: @realxinzhao (Xin Zhao)
Repository: https://github.com/JGCRI/gcamfaostat
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @hugoledoux
Reviewers: @klau506, @HenriKajasilta
Archive: 10.5281/zenodo.10967067
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@klau506 & @HenriKajasilta, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @hugoledoux know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @klau506
📝 Checklist for @HenriKajasilta
The text was updated successfully, but these errors were encountered: