You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
L 218: maybe detail what area_code is ("FAO regions using the area_code ID"?) or how to get it. From which mapping file?
L 219: "dissolutions"
L 244: add space before "Throught"
Captions: some captions start with "The" (e.g. Figure 1, Figure2, Figure 3), and some others with directly the description (e.g. Figure 4, Table 1). Might be better to homogenize
Consider inline code formatting when referring to file names and modules, such as module_xfaostat_L105_DataConnectionToSUA or constants.R. In some cases it is already used, but in some others this notation is missing
In the Statement of need section, you mention the transparency and reproducibility, which I think are key elements of this package. It would be nice to find some reference, mention, or linkage to these concepts throughout the text.
The text was updated successfully, but these errors were encountered:
Thank you so much, @klau506, for the careful reading and great suggestions.
All the suggestions are accepted or addressed accordingly.
For the last comment on transparency and reproducibility, we added a reference to the seminal work by Wilkinson et al. (2016). We agree this is important, though there are not many studies emphasizing the importance of transparency and reproducibility for global economic & multisector modeling.
We will address the remaining comments and keep you posted.
openjournals/joss-reviews#6388
area_code
is ("FAO regions using the area_code ID"?) or how to get it. From which mapping file?module_xfaostat_L105_DataConnectionToSUA
orconstants.R
. In some cases it is already used, but in some others this notation is missingThe text was updated successfully, but these errors were encountered: