Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manuscript Suggestions #7

Closed
9 tasks done
klau506 opened this issue Feb 28, 2024 · 1 comment
Closed
9 tasks done

Manuscript Suggestions #7

klau506 opened this issue Feb 28, 2024 · 1 comment

Comments

@klau506
Copy link

klau506 commented Feb 28, 2024

openjournals/joss-reviews#6388

  • L 51: "for GCAM" or "for the GCAM model"
  • L 80: "from FAOSTAT"
  • L 171: "it inherits"
  • L 218: maybe detail what area_code is ("FAO regions using the area_code ID"?) or how to get it. From which mapping file?
  • L 219: "dissolutions"
  • L 244: add space before "Throught"
  • Captions: some captions start with "The" (e.g. Figure 1, Figure2, Figure 3), and some others with directly the description (e.g. Figure 4, Table 1). Might be better to homogenize
  • Consider inline code formatting when referring to file names and modules, such as module_xfaostat_L105_DataConnectionToSUA or constants.R. In some cases it is already used, but in some others this notation is missing
  • In the Statement of need section, you mention the transparency and reproducibility, which I think are key elements of this package. It would be nice to find some reference, mention, or linkage to these concepts throughout the text.
@realxinzhao
Copy link
Collaborator

Thank you so much, @klau506, for the careful reading and great suggestions.
All the suggestions are accepted or addressed accordingly.
For the last comment on transparency and reproducibility, we added a reference to the seminal work by Wilkinson et al. (2016). We agree this is important, though there are not many studies emphasizing the importance of transparency and reproducibility for global economic & multisector modeling.
We will address the remaining comments and keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants