Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sagercaster] Adding German translation #7443

Merged
merged 3 commits into from
Apr 22, 2020
Merged

[sagercaster] Adding German translation #7443

merged 3 commits into from
Apr 22, 2020

Conversation

clinique
Copy link
Contributor

In response to Issue #7440

Signed-off-by: clinique [email protected]

@clinique clinique changed the title Adding German translation [Sagercaster] Adding German translation Apr 22, 2020
@clinique clinique added the enhancement An enhancement or new feature for an existing add-on label Apr 22, 2020
@clinique clinique linked an issue Apr 22, 2020 that may be closed by this pull request
New German translation for sager binding #7440
Closed
@clinique clinique requested review from cpmeister and cweitkamp April 22, 2020 13:49
@clinique
Forgot last LF
a629ad6 
Signed-off-by: clinique <[email protected]>
@openhab openhab deleted a comment from TravisBuddy Apr 22, 2020
cweitkamp
cweitkamp reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping out. Some minors.

...es/org.openhab.binding.sagercaster/src/main/resources/ESH-INF/i18n/sagercaster_de.properties Outdated Show resolved Hide resolved
...es/org.openhab.binding.sagercaster/src/main/resources/ESH-INF/i18n/sagercaster_de.properties Outdated Show resolved Hide resolved
...es/org.openhab.binding.sagercaster/src/main/resources/ESH-INF/i18n/sagercaster_de.properties Outdated Show resolved Hide resolved
...es/org.openhab.binding.sagercaster/src/main/resources/ESH-INF/i18n/sagercaster_de.properties Outdated Show resolved Hide resolved
@cweitkamp cweitkamp changed the title [Sagercaster] Adding German translation [sagercaster] Adding German translation Apr 22, 2020
@cweitkamp cweitkamp added translation and removed enhancement An enhancement or new feature for an existing add-on labels Apr 22, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @clinique,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@openhab openhab deleted a comment from TravisBuddy Apr 22, 2020
cweitkamp
cweitkamp approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you and @miloit.

@cweitkamp cweitkamp merged commit 41ee4ef into openhab:2.5.x Apr 22, 2020
@cweitkamp cweitkamp added this to the 2.5.5 milestone Apr 22, 2020
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
@clinique
[sagercaster] Added German translation (openhab#7443)
62e6ca2 
* Added German translation

Closes openhab#7440 

Signed-off-by: clinique <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
@clinique clinique deleted the Sager_de branch June 5, 2020 11:14
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@clinique @LoungeFlyZ
[sagercaster] Added German translation (openhab#7443)
c7aa06e 
* Added German translation

Closes openhab#7440 

Signed-off-by: clinique <[email protected]>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@clinique @J-N-K
[sagercaster] Added German translation (openhab#7443)
fc738ee 
* Added German translation

Closes openhab#7440 

Signed-off-by: clinique <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@clinique @CSchlipp
[sagercaster] Added German translation (openhab#7443)
40ddf79 
* Added German translation

Closes openhab#7440 

Signed-off-by: clinique <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@clinique @andrewfg
[sagercaster] Added German translation (openhab#7443)
6c1587b 
* Added German translation

Closes openhab#7440 

Signed-off-by: clinique <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@clinique @andrewfg
[sagercaster] Added German translation (openhab#7443)
e39008f 
* Added German translation

Closes openhab#7440 

Signed-off-by: clinique <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@clinique @andrewfg
[sagercaster] Added German translation (openhab#7443)
b00e803 
* Added German translation

Closes openhab#7440 

Signed-off-by: clinique <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@clinique @andrewfg
[sagercaster] Added German translation (openhab#7443)
9cf5918 
* Added German translation

Closes openhab#7440 

Signed-off-by: clinique <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@clinique @DaanMeijer
[sagercaster] Added German translation (openhab#7443)
beb2dcf 
* Added German translation

Closes openhab#7440 

Signed-off-by: clinique <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@clinique @markus7017
[sagercaster] Added German translation (openhab#7443)
a6f88f5 
* Added German translation

Closes openhab#7440 

Signed-off-by: clinique <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

@cpmeister cpmeister Awaiting requested review from cpmeister

Assignees
No one assigned
Labels
translation
Projects
None yet
Milestone
2.5.5
Development

Successfully merging this pull request may close these issues.

New German translation for sager binding
3 participants
@clinique @TravisBuddy @cweitkamp