Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into f/pipelines-enhancement #2212

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented Nov 22, 2023

Description

Merge latest main into feature branch f/pipelines-enhancement

How Has This Been Tested?

Manually

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Gkrumbach07 and others added 30 commits August 1, 2023 16:40
fixed detected accelerator count

connected accelerator detection

added accelerator UI user flow

hide accelerator dropdown when empty

switched the format of the notebook identifier

added accelerator name to serving runtime resource

added serving runtimes accelerators
commit 9387956
Author: Gage Krumbach <[email protected]>
Date:   Fri Jun 30 14:56:37 2023 -0500

    added accelerator UI user flow

    fixed detected accelerator count

    connected accelerator detection

    added accelerator UI user flow

    hide accelerator dropdown when empty

    switched the format of the notebook identifier

    added accelerator name to serving runtime resource

    added serving runtimes accelerators
commit 26da289
Author: Gage Krumbach <[email protected]>
Date:   Tue Aug 1 16:40:25 2023 -0500

    fix error state in migration

commit 391cbca
Author: Gage Krumbach <[email protected]>
Date:   Tue Aug 1 15:09:25 2023 -0500

    added accelerator detection line

commit 50839ac
Author: Gage Krumbach <[email protected]>
Date:   Thu Jul 27 13:52:24 2023 -0500

    added gpu migration
…upport

fix lint errors in accelerator support
update deployed notebooks and sr on migrate

fixed error logging

remove container migration

Added support for "keep what i have"

soft migrate nvidia gpus to profiles

fix

handle exisiting settings

refactored hooks

remove useRef

simplify functions

small changes to hook

merge hooks together

update cluster role

small changes

bug fixes

small type fix

fixed type issues
…ue-1417

Show non-DS projects in the project table
openshift-merge-bot bot and others added 18 commits November 16, 2023 17:14
…utdated-tags

Update jupyter & ds projects to hide outdated images
…ue-2135

Add spinner, enhance route and error handling for global model serving page
fix popover bug

fix linting issue

remove unused params

fix ProjectView story
…test-fix

fix test fails on project details page and serving runtimes
@christianvogt
Copy link
Contributor Author

/retest

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8cafbe2 into opendatahub-io:f/pipelines-enhancement Nov 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.