Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address PF5-related UI issues #2179

Merged

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Nov 17, 2023

Towards comments in #2041 , most of those issues are fixed with these changes here.

This popover issue requires more investigation and potentially more significant updates to components/logic - marking this PR as a draft for now as I look into a fix here. Fixed ✅

Also will be looking at tests to see the scope of work that will be required - more assistance may be needed, TBD

Description

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@jenny-s51
Copy link
Contributor Author

Popover issue fixed - pf5 feature branch needs rebase again, waiting on #2183

@jenny-s51 jenny-s51 mentioned this pull request Nov 17, 2023
7 tasks
@jenny-s51 jenny-s51 marked this pull request as ready for review November 20, 2023 14:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Nov 20, 2023
fix popover bug

fix linting issue

remove unused params

fix ProjectView story
@andrewballantyne
Copy link
Member

/override "Tests (18.x)"

We'll fix the tests in a follow-up PR. Thanks again for all the help @jenny-s51

Copy link
Contributor

openshift-ci bot commented Nov 20, 2023

@andrewballantyne: Overrode contexts on behalf of andrewballantyne: Tests (18.x)

In response to this:

/override "Tests (18.x)"

We'll fix the tests in a follow-up PR. Thanks again for all the help @jenny-s51

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d3fb2d2 into opendatahub-io:f/pf5-upgrade Nov 20, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants