Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jupyter & ds projects to hide outdated images #2158

Merged

Conversation

andrewballantyne
Copy link
Member

@andrewballantyne andrewballantyne commented Nov 16, 2023

Closes: #2084

Description

Adds filters to both Jupyter tile & DS Projects for version tags that have opendatahub.io/image-tag-outdated annotation.

How Has This Been Tested?

Add the annotation to the ImageStreamTag. If it exists on the tag it will not show up in the Jupyter Tile or DS Projects image-tag selection.

Test Impact

Wrote tests for modified frontend code. Backend remains untested as it is deprecated.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@andrewballantyne
Copy link
Member Author

cc @harshad16 FYI

@harshad16
Copy link
Member

To be tested with these devflags for workbenches:

workbenches:
      devFlags:
        manifests:
          - contextDir: components/odh-notebook-controller/config
            sourcePath: ''
            uri: 'https://github.com/opendatahub-io/kubeflow/tarball/v1.7.0-5'
          - contextDir: components/notebook-controller/config
            sourcePath: ''
            uri: 'https://github.com/opendatahub-io/kubeflow/tarball/v1.7.0-5'
          - contextDir: manifests
            sourcePath: ''
            uri: 'https://github.com/opendatahub-io/notebooks/tarball/2023b'
      managementState: Managed

@harshad16
Copy link
Member

Tested with the PR images and workbench
Screenshot from 2023-11-16 16-05-57
Screenshot from 2023-11-16 16-07-21

thanks for the work.
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a0de3fd into opendatahub-io:main Nov 16, 2023
6 checks passed
@andrewballantyne andrewballantyne deleted the handle-outdated-tags branch June 26, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Hiding outdated workbench image version from Dashboard
2 participants