-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change options to config based on BasePlugin #314
fix: change options to config based on BasePlugin #314
Conversation
closes open-telemetry#313 Signed-off-by: Olivier Albertini <[email protected]>
4257164
to
66f33d7
Compare
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
==========================================
- Coverage 98% 97.93% -0.07%
==========================================
Files 101 98 -3
Lines 4912 4455 -457
Branches 412 384 -28
==========================================
- Hits 4814 4363 -451
+ Misses 98 92 -6
|
@@ -51,13 +51,11 @@ let grpcClientModule: object; | |||
export class GrpcPlugin extends BasePlugin<grpc> { | |||
static readonly component = 'grpc'; | |||
|
|||
options!: GrpcPluginOptions; | |||
protected _config!: GrpcPluginOptions; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why protected and not private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why protected and not private?
It's protected on BasePlugin
.
Which problem is this PR solving?
Short description of the changes
undefined
issue about _config property if we intend to use it outsidePluginLoader
. (related to Plugin config optional vs required #210)