-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-http): add example #318
feat(plugin-http): add example #318
Conversation
ade6b7d
to
36509bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
examples/http/setup.js
Outdated
// need ignoreOutgoingUrls: [/spans/] to avoid infinity loops | ||
// TODO: manage this situation | ||
const zipkinExporter = new ZipkinExporter(options); | ||
exporter = new SimpleSpanProcessor(zipkinExporter); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/exporter/processor/g
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think we should use BatchSpanProcessor
in case of Zipkin exporter (dependency on #238). Jaeger library has its own batching mechanism, so it makes sense to use SimpleSpanProcessor
with Jaeger exporter.
6aeb847
to
00d6798
Compare
@OlivierAlbertini Looks like all the dependent PRs are merged, Could you please change this to Ready to Review. |
00d6798
to
2f43d7a
Compare
I will give it a try on Jaeger exporter. |
@OlivierAlbertini If you want, you can use this image for the Jaeger exporter example. I did some hacking to generate this with your example. I will add agenda for tomorrow's SIG meeting to discuss about this. |
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
========================================
+ Coverage 97.97% 98% +0.02%
========================================
Files 101 101
Lines 4891 4912 +21
Branches 413 415 +2
========================================
+ Hits 4792 4814 +22
+ Misses 99 98 -1
|
Ping, for more reviews. |
closes open-telemetry#245 Signed-off-by: Olivier Albertini <[email protected]>
Signed-off-by: Olivier Albertini <[email protected]>
Signed-off-by: Olivier Albertini <[email protected]>
Signed-off-by: Olivier Albertini <[email protected]>
3311b22
to
93bd17c
Compare
@OlivierAlbertini Thanks for the example. #335 and #340 are not a real blocker for this one and let's keep |
…pes (open-telemetry#318) Signed-off-by: Geoffrey Goodman <[email protected]>
Which problem is this PR solving?
Short description of the changes
I will remove the draft status once PRs will be merged:
fix(plugin-http): improve formatting for url attribute #317fix: change options to config based on BasePlugin #314fix: pluginLoader for core modules #312feat(exporter-jaeger): add forceFlush and timeout options #301feat(node-sdk): make config optional #331PR to merge:
TODO:
Working with Zipkin
See Files changed section (image)
And below attributes:
Working with Jaeger