Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-sdk): make config optional #331

Merged

Conversation

OlivierAlbertini
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • make config optional
  • remove unnecessary empty object in Object.assign

@OlivierAlbertini OlivierAlbertini merged commit e6d9986 into open-telemetry:master Sep 25, 2019
@OlivierAlbertini OlivierAlbertini deleted the feature/node-sdk-config branch September 25, 2019 01:37
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* chore: document load instrumentation

* chore: document load instrumentation

* chore: adding example for document load, fixing context

* chore: lint fix

* chore: updating documentation

* chore: reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make NodeTracer config optional
5 participants