Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin config optional vs required #210

Closed
OlivierAlbertini opened this issue Aug 21, 2019 · 2 comments
Closed

Plugin config optional vs required #210

OlivierAlbertini opened this issue Aug 21, 2019 · 2 comments
Labels
Discussion Issue or PR that needs/is extended discussion.

Comments

@OlivierAlbertini
Copy link
Member

Hello,

I would like your feedback on this topic, because I don't have a strong opinion on it. I'm referring to https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-types/src/trace/instrumentation/Plugin.ts#L32
comparing to Opencensus

It's different.

From my point of view, if we do not intend to use plugin alone (without PluginLoader) we should let PluginLoader pass the config and make the param mandatory (like Opencensus).
If we make it optional, each plugin will must initialize the config with dummy object...
@mayurkale22 mayurkale22 mentioned this issue Aug 22, 2019
Closed
@danielkhan danielkhan added the Discussion Issue or PR that needs/is extended discussion. label Aug 28, 2019
@OlivierAlbertini
Copy link
Member Author

Another argument for making config mandatory https://github.com/open-telemetry/opentelemetry-js/pull/227/files#diff-58617f715d03c32994cc1932cee56146R50

@OlivierAlbertini OlivierAlbertini mentioned this issue Sep 22, 2019
Merged
@vmarchaud
Copy link
Member

Closing since #314 has been merged

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@MarkSeufert
Contributing guide git reference changes (open-telemetry#210)
521b17b 
* Corrected Contributing guide's git references

* removed changes from previous commit

* Corrected Contributing guide's git references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielkhan @vmarchaud @OlivierAlbertini