Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins don't get config #313

Closed
OlivierAlbertini opened this issue Sep 22, 2019 · 0 comments · Fixed by #314
Closed

plugins don't get config #313

OlivierAlbertini opened this issue Sep 22, 2019 · 0 comments · Fixed by #314
Assignees
@OlivierAlbertini

Comments

@OlivierAlbertini
Copy link
Member

Based on this PR #229
We shouldn't use options (public) but _config (protected) coming from BasePlugin.

Impacted plugins:

  • grpc
  • http
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Sep 22, 2019
@OlivierAlbertini
fix: change options to config based on BasePlugin
4257164 
closes open-telemetry#313

Signed-off-by: Olivier Albertini <[email protected]>
@OlivierAlbertini OlivierAlbertini mentioned this issue Sep 22, 2019
Merged
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Sep 22, 2019
@OlivierAlbertini
fix: change options to config based on BasePlugin
66f33d7 
closes open-telemetry#313

Signed-off-by: Olivier Albertini <[email protected]>
@OlivierAlbertini OlivierAlbertini self-assigned this Sep 22, 2019
mayurkale22 pushed a commit that referenced this issue Sep 24, 2019
@OlivierAlbertini @mayurkale22
fix: change options to config based on BasePlugin (#314)
013a1e4 
closes #313

Signed-off-by: Olivier Albertini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlivierAlbertini OlivierAlbertini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: change options to config based on BasePlugin VilledeMontreal/opentelemetry-js
1 participant
@OlivierAlbertini