-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mongodb types fails to compile with latest tsc v4.8 #1141
Merged
blumamir
merged 4 commits into
open-telemetry:main
from
epsagon:fix/fix-compile-examples-failure
Aug 31, 2022
Merged
fix: mongodb types fails to compile with latest tsc v4.8 #1141
blumamir
merged 4 commits into
open-telemetry:main
from
epsagon:fix/fix-compile-examples-failure
Aug 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
- Coverage 96.07% 92.38% -3.69%
==========================================
Files 14 28 +14
Lines 892 1511 +619
Branches 191 348 +157
==========================================
+ Hits 857 1396 +539
- Misses 35 115 +80
|
osherv
changed the title
fix(compile-examples): fixed compile examples error
fix: mongodb types not fail compilation with latest tsc v4.8
Aug 31, 2022
MSNev
approved these changes
Aug 31, 2022
Flarna
approved these changes
Aug 31, 2022
blumamir
approved these changes
Aug 31, 2022
blumamir
changed the title
fix: mongodb types not fail compilation with latest tsc v4.8
fix: mongodb types fails to compile with latest tsc v4.8
Aug 31, 2022
Thank you @osherv |
Merged
This was referenced Sep 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some sub-packages that used the latest typescript version and caused errors against the deprecated @types/mongodb: 3.6.20 dependency.
Short description of the changes
Moved the deprecated MongoDB dependency to a devDependency:
@types/mongodb
in the instrumentation itself was minor.All the places that used the MongoDB types were replaced with
any
as it applied in many other instrumentations,in order to avoid the use of deprecated dependencies.
Aligned all typescript versions in the project to 4.3.5:
There were three packages that were used latest typescript version (duo to "^version):
Also, we have to think about how to restrict those typescript version update changes.
Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.