fix: mongodb types fails to compile with latest tsc v4.8 (#1141)

* fix(compile-examples): fixed compile examples error * fix(compile-examples): align all typescipt versions to 4.3.5 * fix(compile-examples): align all typescipt versions to 4.3.5 * fix(compile-examples): moved @types/mongodb to a dev dependency
open-telemetry · Aug 31, 2022 · ec9ee13 · ec9ee13
1 parent 11ab701
commit ec9ee13
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 11 deletions.
diff --git a/detectors/node/opentelemetry-resource-detector-docker/package.json b/detectors/node/opentelemetry-resource-detector-docker/package.json
@@ -48,7 +48,7 @@
     "rimraf": "3.0.2",
     "sinon": "14.0.0",
     "ts-mocha": "10.0.0",
-    "typescript": "^4.5.5"
+    "typescript": "4.3.5"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.0.0"

diff --git a/plugins/node/opentelemetry-instrumentation-express/examples/package.json b/plugins/node/opentelemetry-instrumentation-express/examples/package.json
@@ -47,6 +47,6 @@
   "devDependencies": {
     "@types/express": "^4.17.13",
     "ts-node": "^10.6.0",
-    "typescript": "^4.6.2"
+    "typescript": "4.3.5"
   }
 }
diff --git a/plugins/node/opentelemetry-instrumentation-koa/examples/package.json b/plugins/node/opentelemetry-instrumentation-koa/examples/package.json
@@ -46,7 +46,7 @@
   "devDependencies": {
     "cross-env": "^6.0.0",
     "ts-node": "^10.6.0",
-    "typescript": "^4.6.2",
+    "typescript": "4.3.5",
     "@types/koa": "^2.13.5"
   }
 }
diff --git a/plugins/node/opentelemetry-instrumentation-mongodb/package.json b/plugins/node/opentelemetry-instrumentation-mongodb/package.json
@@ -59,6 +59,7 @@
     "gts": "3.1.0",
     "mocha": "7.2.0",
     "mongodb": "3.6.11",
+    "@types/mongodb": "3.6.20",
     "nyc": "15.1.0",
     "rimraf": "3.0.2",
     "test-all-versions": "5.0.1",
@@ -67,8 +68,7 @@
   },
   "dependencies": {
     "@opentelemetry/instrumentation": "^0.31.0",
-    "@opentelemetry/semantic-conventions": "^1.0.0",
-    "@types/mongodb": "3.6.20"
+    "@opentelemetry/semantic-conventions": "^1.0.0"
   },
   "homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-mongodb#readme"
 }
diff --git a/plugins/node/opentelemetry-instrumentation-mongodb/src/instrumentation.ts b/plugins/node/opentelemetry-instrumentation-mongodb/src/instrumentation.ts
@@ -33,7 +33,6 @@ import {
   DbSystemValues,
   SemanticAttributes,
 } from '@opentelemetry/semantic-conventions';
-import type * as mongodb from 'mongodb';
 import {
   CursorState,
   MongodbCommandType,
@@ -47,9 +46,7 @@ import {
 import { VERSION } from './version';
 
 /** mongodb instrumentation plugin for OpenTelemetry */
-export class MongoDBInstrumentation extends InstrumentationBase<
-  typeof mongodb
-> {
+export class MongoDBInstrumentation extends InstrumentationBase {
   constructor(protected override _config: MongoDBInstrumentationConfig = {}) {
     super('@opentelemetry/instrumentation-mongodb', VERSION, _config);
   }
@@ -59,7 +56,7 @@ export class MongoDBInstrumentation extends InstrumentationBase<
     const { v4Patch, v4Unpatch } = this._getV4Patches();
 
     return [
-      new InstrumentationNodeModuleDefinition<typeof mongodb>(
+      new InstrumentationNodeModuleDefinition<any>(
         'mongodb',
         ['>=3.3 <4'],
         undefined,
@@ -73,7 +70,7 @@ export class MongoDBInstrumentation extends InstrumentationBase<
           ),
         ]
       ),
-      new InstrumentationNodeModuleDefinition<typeof mongodb>(
+      new InstrumentationNodeModuleDefinition<any>(
         'mongodb',
         ['4.*'],
         undefined,