You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed this error when performing an npm install on a project that includes this package
Note: I tried simply deleting the line from the package.json but got this error when trying to run npm run compile from \plugins\node\opentelemetry-instrumentation-mongodb
The top error is the only one from an src file, all other are from a test, which I believe is based on the npm version (which would need to be updated and create a new release as part of this fix)
The text was updated successfully, but these errors were encountered:
The problem is that current version of the instrumentation requires the types. Removing the dependency to @types/mongodb would require to add one to mongodb which would be quite bad.
Work is ongoing to remove the need to include types dependencies in instrumentations (e.g. #1036, #1066) but it will take a while until this is fixed. As usual help is welcome!
@mic-max@Flarna Hey :) According to this PR: #1141
The dependencies of @types/mongo are now devDependencies only.
I think it met your requirements, right?
@osherv Yes, I believe that does it! Now projects that use this module will no longer see this message when installing it as it will not fetch devDependencies
The dependency is marked as deprecated here
It says
This is the package.json file listing the dependency
I noticed this error when performing an
npm install
on a project that includes this packageNote: I tried simply deleting the line from the
package.json
but got this error when trying to runnpm run compile
from\plugins\node\opentelemetry-instrumentation-mongodb
The top error is the only one from an src file, all other are from a test, which I believe is based on the npm version (which would need to be updated and create a new release as part of this fix)
The text was updated successfully, but these errors were encountered: