Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin/restrict typescript version for all components #1145

Closed
osherv opened this issue Sep 1, 2022 · 2 comments
Closed

Pin/restrict typescript version for all components #1145

osherv opened this issue Sep 1, 2022 · 2 comments

Comments

@osherv
Copy link
Member

osherv commented Sep 1, 2022

Today, every sub-package in the repo specifies its own typescript version.
There is no restriction and every package can use a different version of typescript which can cause many collisions and errors like: #1141

I wonder how can we avoid those collisions in the future.
We want that all of our packages will use the same version (currently 4.3.5).

@blumamir
Copy link
Member

blumamir commented Sep 1, 2022

Actually, typescript is already a dependency of the monorepo root here, so I guess it's reasonable that sub packages should be able to pick it up from there instead of specifying the dependency again and again.

I guess the package manager can sometimes be confused when executing various scripts that invoke tsc, but that is easy to test if you are up for it 😉

@osherv
Copy link
Member Author

osherv commented Sep 1, 2022

Be sure i am :)

@osherv osherv closed this as completed Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants