Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http content size semantic conventions #905

Merged

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Jul 6, 2020

Resolves #890

@XSAM XSAM force-pushed the feature/http-content-size-conventions branch 4 times, most recently from 7bda913 to 8b53c76 Compare July 6, 2020 16:12
Copy link
Contributor

@evantorrie evantorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know whether it needs to be in this PR, but we should look at including these in httptrace and othttp where appropriate.

@XSAM XSAM force-pushed the feature/http-content-size-conventions branch from 8b53c76 to 049d690 Compare July 7, 2020 03:12
@XSAM
Copy link
Member Author

XSAM commented Jul 7, 2020

Since these attribute names already added to the semantic conventions, we should provide the predefined variable to standard package which is convenient for end-user, they can use the variable directly without writing it by hand.


we should look at including these in httptrace and othttp where appropriate.

@evantorrie I add http.request_content_length to standard.httpBasicAttributesFromHTTPRequest, it will bring this variable to httptrace.Extract, othttp.Handler and othttp.Transport

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good outside of the const naming.

api/standard/trace.go Outdated Show resolved Hide resolved
@MrAlias MrAlias added this to the Implement v0.6.0 Specification milestone Jul 7, 2020
@XSAM XSAM force-pushed the feature/http-content-size-conventions branch from 049d690 to 48105cf Compare July 8, 2020 02:47
@MrAlias
Copy link
Contributor

MrAlias commented Jul 8, 2020

@evantorrie can you open an issue to address integrating these labels to the mentioned instrumentation packages if you think there is more work still?

@MrAlias MrAlias merged commit 03cd779 into open-telemetry:master Jul 8, 2020
@XSAM XSAM deleted the feature/http-content-size-conventions branch July 8, 2020 23:49
@MrAlias MrAlias mentioned this pull request Jul 9, 2020
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add semantic conventions for http content size to the api/standard package
5 participants