-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http content size semantic conventions #905
Add http content size semantic conventions #905
Conversation
7bda913
to
8b53c76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8b53c76
to
049d690
Compare
Since these attribute names already added to the semantic conventions, we should provide the predefined variable to standard package which is convenient for end-user, they can use the variable directly without writing it by hand.
@evantorrie I add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good outside of the const naming.
Signed-off-by: Sam Xie <[email protected]>
Signed-off-by: Sam Xie <[email protected]>
Signed-off-by: Sam Xie <[email protected]>
Signed-off-by: Sam Xie <[email protected]>
Signed-off-by: Sam Xie <[email protected]>
049d690
to
48105cf
Compare
@evantorrie can you open an issue to address integrating these labels to the mentioned instrumentation packages if you think there is more work still? |
[Requirements](https://github.com/open-telemetry/community/blob/master/community-membership.md#requirements-2) - [X] >=10 substantive contributions (open-telemetry/opentelemetry-go-contrib#134, open-telemetry/opentelemetry-go-contrib#153, open-telemetry/opentelemetry-go-contrib#221, open-telemetry/opentelemetry-go-contrib#298, open-telemetry/opentelemetry-go-contrib#303, open-telemetry#796, open-telemetry#905, open-telemetry#986, open-telemetry#1044, open-telemetry#1031, open-telemetry#1102) - [X] Active >1mo - [X] add to CODEOWNERS (done in this pull) - [X] Add to CONTRIBUTING.md (done in this pull) - [X] Maintainer nomination: @MrAlias - [ ] Other maintainer(s) (@Aneurysm9) sign-off - [ ] Add to @open-telemetry/go-approvers
Resolves #890