Add @XSAM as an approver #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd and
lizthegrey
as code owners
XSAM
approved these changes
Sep 1, 2020
jmacd
approved these changes
Sep 1, 2020
|
cycling to see if it clears GitHub triggers not recognizing the approvals. |
|
Oh, that made it clearer. Looks like since we specify the CODEOWNERS file to be owned by maintainers we need @Aneurysm9 specifically to approve this. TIL |
Aneurysm9
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the contrib repo version of open-telemetry/opentelemetry-go#1110
Requirements
WithSyncerwithWithBatcherin examples opentelemetry-go#1044, Move content length out of basic attributes opentelemetry-go#1031, Rename global SetTraceProvider and TraceProvider opentelemetry-go#1102)