Add instrumentation example for Kafka #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSAM
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
paivagustavo
as code owners
XSAM
force-pushed
the
feature/kafka-instrumentation
branch
from
39e3052 to
31e7e26
Compare
XSAM
force-pushed
the
feature/kafka-instrumentation
branch
from
31e7e26 to
3c5720c
Compare
Aneurysm9
approved these changes
Jul 28, 2020
MrAlias
approved these changes
Jul 29, 2020
Merged
6 tasks
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Aug 28, 2020
[Requirements](https://github.com/open-telemetry/community/blob/master/community-membership.md#requirements-2) - [X] >=10 substantive contributions (open-telemetry/opentelemetry-go-contrib#134, open-telemetry/opentelemetry-go-contrib#153, open-telemetry/opentelemetry-go-contrib#221, open-telemetry/opentelemetry-go-contrib#298, open-telemetry/opentelemetry-go-contrib#303, open-telemetry#796, open-telemetry#905, open-telemetry#986, open-telemetry#1044, open-telemetry#1031, open-telemetry#1102) - [X] Active >1mo - [X] add to CODEOWNERS (done in this pull) - [X] Add to CONTRIBUTING.md (done in this pull) - [X] Maintainer nomination: @MrAlias - [ ] Other maintainer(s) (@Aneurysm9) sign-off - [ ] Add to @open-telemetry/go-approvers
This was referenced Aug 28, 2020
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* Add stdout trace exporter (#134) * Update go.mod and go.sum * Do not use assert in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #87
Dockerfilewith example app showing instrumentationBTW, I add a wrapper for the Kafka consumer group, which dd-trace-go does not implement that.