Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLPLogExporter tests #2873

Closed
cijothomas opened this issue Feb 7, 2022 · 8 comments · Fixed by #4296, #4578 or #4610
Closed

OTLPLogExporter tests #2873

cijothomas opened this issue Feb 7, 2022 · 8 comments · Fixed by #4296, #4578 or #4610
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package

Comments

@cijothomas
Copy link
Member

#2871 - A very basic test is added here. Opening an issue to track adding more tests to OTLP Log Exporter. The exporter itself is not fully ready and is tracked here - #2482

@cijothomas cijothomas added help wanted Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package labels Feb 7, 2022
@dbgoytia
Copy link

Hi @cijothomas! I'd like to contribute to this repo. Do you know if this is still active? I'm new to the codebase but pretty excited to get started!

@cijothomas
Copy link
Member Author

Yes! This issue is still open. You can start by looking at the existing tests and identify gaps. The issue description has a link to PR adding basic tests.

@moonbox3
Copy link
Contributor

Hi @dbgoytia and @cijothomas. I am wondering if this issue is still open and needing help? Please let me know. Thanks.

@cijothomas
Copy link
Member Author

@moonbox3 This is still open! Sorry for getting back very late.

@mfogliatto
Copy link
Contributor

mfogliatto commented Feb 25, 2023

@cijothomas I see that additional unit tests were added since you first introduced OtlpLogExporterTests in #2871. In fact, the "TODO" comment no longer exists and seems there are now unit tests asserting all Attributes, Severity, TraceId and SpanId.

Do you think there's still any case missing that I could add?

@cijothomas
Copy link
Member Author

Scopes are missing from the tests. It may no longer be a "good first issue" to add coverage for that, as testing Scopes might be non-trivial. Do you want to explore?

@mfogliatto
Copy link
Contributor

Scopes are missing from the tests. It may no longer be a "good first issue" to add coverage for that, as testing Scopes might be non-trivial. Do you want to explore?

Sure sounds good! I'll give it a try. In the meantime I have introduced in the PR above some basic tests to increase code coverage in a related class.

@cijothomas
Copy link
Member Author

Reopening as Scopes are not yet part of the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
4 participants