-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTLPLogExporter tests #2873
Comments
Hi @cijothomas! I'd like to contribute to this repo. Do you know if this is still active? I'm new to the codebase but pretty excited to get started! |
Yes! This issue is still open. You can start by looking at the existing tests and identify gaps. The issue description has a link to PR adding basic tests. |
Hi @dbgoytia and @cijothomas. I am wondering if this issue is still open and needing help? Please let me know. Thanks. |
@moonbox3 This is still open! Sorry for getting back very late. |
@cijothomas I see that additional unit tests were added since you first introduced Do you think there's still any case missing that I could add? |
Scopes are missing from the tests. It may no longer be a "good first issue" to add coverage for that, as testing Scopes might be non-trivial. Do you want to explore? |
Sure sounds good! I'll give it a try. In the meantime I have introduced in the PR above some basic tests to increase code coverage in a related class. |
Reopening as Scopes are not yet part of the tests |
#2871 - A very basic test is added here. Opening an issue to track adding more tests to OTLP Log Exporter. The exporter itself is not fully ready and is tracked here - #2482
The text was updated successfully, but these errors were encountered: