Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLPLogExporter bug fix to handle null EventName #2871

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

cijothomas
Copy link
Member

Fixes #2870

Changes

Apart from null exception fix, this also adds a very basic test for OTLP LogRecord. This is very basic, and a step1 towards adding proper tests (currently there are no tests for OTLP Logs)

@cijothomas cijothomas requested a review from a team February 7, 2022 19:49
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #2871 (b648576) into main (fe7b917) will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2871      +/-   ##
==========================================
+ Coverage   83.76%   84.10%   +0.34%     
==========================================
  Files         250      245       -5     
  Lines        8882     8777     -105     
==========================================
- Hits         7440     7382      -58     
+ Misses       1442     1395      -47     
Impacted Files Coverage Δ
...etryProtocol/Implementation/LogRecordExtensions.cs 56.66% <100.00%> (+56.66%) ⬆️
....TelemetryHttpModule/TelemetryHttpModuleOptions.cs 0.00% <0.00%> (-90.00%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️
....AspNet.TelemetryHttpModule/TelemetryHttpModule.cs 0.00% <0.00%> (-5.27%) ⬇️
...umentation.AspNet/Implementation/HttpInListener.cs
...rumentation.AspNet/AspNetInstrumentationOptions.cs
...Implementation/AspNetInstrumentationEventSource.cs
...ry.Instrumentation.AspNet/AspNetInstrumentation.cs
...entation.AspNet/TracerProviderBuilderExtensions.cs
...metryProtocol/Implementation/ActivityExtensions.cs 86.75% <0.00%> (+0.91%) ⬆️
... and 6 more

@cijothomas cijothomas merged commit 7ce2e4c into open-telemetry:main Feb 7, 2022
@cijothomas cijothomas mentioned this pull request Feb 7, 2022
@cijothomas cijothomas deleted the cijothomas/otlplogfix1 branch February 7, 2022 20:22
@glucaci
Copy link
Contributor

glucaci commented Feb 13, 2022

There are any plans to release this fix soon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application crash when EventId contains null-message (after update to rc2/rc9)
3 participants