Add missing assertions to OtlpLogExporterTests #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mfogliatto
force-pushed
the
mfogliatto/add-otlplogexporter-scope-tests
branch
from
f3c96e0 to
a5ec6eb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4610 +/- ##
==========================================
+ Coverage 84.88% 84.90% +0.02%
==========================================
Files 313 313
Lines 12604 12604
==========================================
+ Hits 10699 10702 +3
+ Misses 1905 1902 -3 |
vishweshbankwar
approved these changes
Jun 26, 2023
reyang
approved these changes
Jun 26, 2023
utpilla
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2873
Changes
Add missing assertions to OtlpLogExporterTests
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes N/A