Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ToOtlpLog unit tests for scopes (cont.) #4578

Conversation

mfogliatto
Copy link
Contributor

Fixes #2873

Changes

  • Add tests for multiple scope types
  • Add tests for duplicated keys scenarios

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes N/A
  • Changes in public API reviewed (if applicable) N/A

@mfogliatto mfogliatto requested a review from a team June 10, 2023 08:32
@mfogliatto mfogliatto changed the title Add OtlpLogExporter scope tests (cont.) Add ToOtlpLog unit tests for scopes (cont.) Jun 10, 2023
This is required as `Dictionary` in net462 does not expose a ctor
that takes an `IEnumerable`, thus requiring a different test setup.
@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #4578 (3df1a8b) into main (b7821f7) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 3df1a8b differs from pull request most recent head 3824af8. Consider uploading reports for the commit 3824af8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4578      +/-   ##
==========================================
+ Coverage   85.08%   85.15%   +0.07%     
==========================================
  Files         312      320       +8     
  Lines       12532    12733     +201     
==========================================
+ Hits        10663    10843     +180     
- Misses       1869     1890      +21     

see 17 files with indirect coverage changes

Copy link
Contributor

@utpilla utpilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments which are not blocking this PR.

Thanks @mfogliatto for adding these tests!

@utpilla utpilla merged commit 7333a55 into open-telemetry:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLPLogExporter tests
2 participants