-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ToOtlpLog unit tests for scopes (cont.) #4578
Add ToOtlpLog unit tests for scopes (cont.) #4578
Conversation
This is required as `Dictionary` in net462 does not expose a ctor that takes an `IEnumerable`, thus requiring a different test setup.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4578 +/- ##
==========================================
+ Coverage 85.08% 85.15% +0.07%
==========================================
Files 312 320 +8
Lines 12532 12733 +201
==========================================
+ Hits 10663 10843 +180
- Misses 1869 1890 +21 |
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpLogExporterTests.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpLogExporterTests.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpLogExporterTests.cs
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpLogExporterTests.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpLogExporterTests.cs
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpLogExporterTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments which are not blocking this PR.
Thanks @mfogliatto for adding these tests!
Fixes #2873
Changes
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes N/A