-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OtlpLogExporter.Export method tests #4236
Add OtlpLogExporter.Export method tests #4236
Conversation
|
39a7789
to
283f7a4
Compare
@mfogliatto We'll need you to sign the CLA part. The Bot message should have all the instructions. You may want to consult your company policies if you are contributing as part of a company. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
/easycla |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4236 +/- ##
==========================================
- Coverage 85.57% 84.36% -1.22%
==========================================
Files 291 296 +5
Lines 11398 11791 +393
==========================================
+ Hits 9754 9947 +193
- Misses 1644 1844 +200
|
dd54e3d
to
1d27429
Compare
Close PR and re-raised a separate one, as EasyCLA kept failing even after signing the agreement. |
Fixes #2873.
Changes
Adds the following unit tests in
OtlpLogExporterTests
to increaseOtlpLogExporter
's code coverage to ~100%:For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes N/AReferences
Codecov: https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpLogExporter.cs