Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cartservice] - Add Exemplars to Cart Service #1830

Merged
merged 11 commits into from
Dec 13, 2024
Merged

[cartservice] - Add Exemplars to Cart Service #1830

merged 11 commits into from
Dec 13, 2024

Conversation

julianocosta89
Copy link
Member

@julianocosta89 julianocosta89 commented Dec 12, 2024 •
edited
Loading

Changes

This PR adds exemplars to Cart Service.
I've followed this example: https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/metrics/exemplars

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@julianocosta89 julianocosta89 requested a review from a team as a code owner December 12, 2024 12:25
@julianocosta89 julianocosta89 marked this pull request as draft December 12, 2024 12:25
Kielek
Kielek reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider spliting this PR into 2 parts.
Bump packages.
All other things

src/cartservice/src/cartstore/ValkeyCartStore.cs Show resolved Hide resolved
src/cartservice/src/cartservice.csproj Outdated Show resolved Hide resolved
Kielek
Kielek reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to add suffixes Meter/Source. It is polluting only the names/real measurements.

src/cartservice/src/Program.cs Outdated Show resolved Hide resolved
src/cartservice/src/Program.cs Outdated Show resolved Hide resolved
src/cartservice/src/cartstore/ValkeyCartStore.cs Outdated Show resolved Hide resolved
@julianocosta89 @Kielek
Apply suggestions from code review
aa1725d 
Co-authored-by: Piotr Kiełkowicz <[email protected]>
@julianocosta89 julianocosta89 marked this pull request as ready for review December 13, 2024 10:21
@julianocosta89 julianocosta89 changed the title [WIP] [cartservice] - Add Exemplars to Cart Service [cartservice] - Add Exemplars to Cart Service Dec 13, 2024
@julianocosta89
Copy link
Member Author

@Kielek thanks for all the reviews and guidance 😊
It should be good to go!
Screenshot 2024-12-13 at 11 22 10

Kielek
Kielek approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Dec 13, 2024
Closed
Merged
Merged
@puckpuck puckpuck merged commit 43f448c into open-telemetry:main Dec 13, 2024
31 of 32 checks passed
@julianocosta89 julianocosta89 deleted the cartservice-add-exemplars branch December 14, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kielek Kielek Kielek approved these changes

@puckpuck puckpuck puckpuck approved these changes

@alanwest alanwest Awaiting requested review from alanwest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianocosta89 @puckpuck @Kielek