[cart]: rename cartservice to cart #1834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs-update-required
| @@ -55,7 +55,7 @@ | |||
| }, | |||
| "defaultVariant": "off" | |||
| }, | |||
| "cartServiceFailure": { | |||
| "cartFailure": { | |||
There was a problem hiding this comment.
This also needs to be updated in the docs
|
Would it be too much to ask to have #1830 merged first? Otherwise I'll get plenty of merge conflicts 😭 |
|
Closing this one because of merge conflicts, and will re-submit as a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Renames accountingservice to accounting.
This is part of getting all services renamed based on the overall #1788 effort for all components in the demo.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.