[demo] Add Cart service exemplars doc #5788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
puckpuck
reviewed
Dec 13, 2024
puckpuck
approved these changes
Dec 13, 2024
|
I need to update the screenshot based on @puckpuck's change in the Dashboard |
chalin
requested changes
Dec 14, 2024
There was a problem hiding this comment.
Since the image is specific to the cart service, I suggest the following:
- Create
content/en/docs/demo/services/cart/ - Move and rename
content/en/docs/demo/services/cart.mdtocontent/en/docs/demo/services/cart/index.md - Move and rename
content/en/docs/demo/screenshots/cart-service-exemplars.pngtocontent/en/docs/demo/services/cart/exemplars.png - Adjust the in-page link to the image:
/cc @svrnm
|
@chalin thanks for the suggestions. |
svrnm
approved these changes
Dec 16, 2024
|
/fix:refcache |
|
You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12353560584 |
|
IMPORTANT: (RE-)RUN
|
chalin
reviewed
Dec 16, 2024
|
/fix:all |
|
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12353706272 |
|
IMPORTANT: (RE-)RUN
|
Co-authored-by: Pierre Tessier <[email protected]>
chalin
force-pushed
the
demo/add-cart-service-exemplars-doc
branch
from
1f0edfa to
db5e629
Compare
chalin
approved these changes
Dec 16, 2024
|
We have all necessary approvals. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation to the Exemplars added to the Cart service in the Demo.
It depends on the following issues to be merged: