Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] Add Exemplars Dashboard #1836

Conversation

julianocosta89
Copy link
Member

@julianocosta89 julianocosta89 commented Dec 13, 2024

Changes

Companion PR of #1830.
This PR adds a Dashboard to Grafana to view Exemplars added to CartService.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@julianocosta89 julianocosta89 requested a review from a team as a code owner December 13, 2024 11:10
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Dec 13, 2024
@puckpuck
Copy link
Contributor

I found that the exemplar links to Jaeger would result in not-found traces because they expired out of Jaeger too quickly. Only after manually increasing Jaeger's capacity in docker-compose was I able to get the links to work. To make this feature usable, we need to give Jaeger more trace capacity and memory limits.

This is likely for another issue, but we may want to examine the telemetry load as a whole within the context of the demo. There may be telemetry optimizations we could make, maybe even altering the load velocity so telemetry can live in memory longer before aging out due to memory limits.

@puckpuck
Copy link
Contributor

I updated the dashboard in the example to better represent histogram metrics with exemplars.

I also made some changes to the load generator to reduce the number of users to 5, thus, reducing the number of traces per second going into Jaeger. I also increased the memory for Jaeger to 1200M and the max traces to 25000. Together, this allows for about 10 mins worth of traces in Jaeger that can be linked to the recent exemplars in the Grafana dashboard.
Screenshot 2024-12-13 at 9 03 11 PM

@julianocosta89
Copy link
Member Author

Oh wow!
This is awesome!

Thanks @puckpuck!!!

@julianocosta89 julianocosta89 merged commit fa7847e into open-telemetry:main Dec 16, 2024
31 checks passed
@julianocosta89 julianocosta89 deleted the grafana/add-exemplars-dashboard branch December 16, 2024 10:01
@CharlieTLe
Copy link
Contributor

Very cool, thanks for setting this up. I did a talk at KubeCon about exemplars using this repo. It might be worth linking to for more info about how it works.

https://www.youtube.com/watch?v=zYF1JIZmpI4&list=PLj6h78yzYM2Pw4mRw4S-1p_xLARMqPkA7&index=136

@julianocosta89
Copy link
Member Author

Very cool, thanks for setting this up. I did a talk at KubeCon about exemplars using this repo. It might be worth linking to for more info about how it works.

https://www.youtube.com/watch?v=zYF1JIZmpI4&list=PLj6h78yzYM2Pw4mRw4S-1p_xLARMqPkA7&index=136

This is really cool!
Thanks for sharing @CharlieTLe 🤩🤩🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants