-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve scrapers/mdatagen tool to produce more user-friendly code and support user settings #10904
Comments
@dmitryax I would like to work on |
@dmitryax I would like to work on filesystemscraper receiver. |
@abhide sounds good, thanks! I converted the action item into another issue open-telemetry/opentelemetry-collector-contrib#7136 |
@dmitryax I would like to work on the |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
transferred issue as mdatagen lives in the core repo now |
Metrics Builder for Scraper Receivers
Design document: https://docs.google.com/document/d/1OwDbIFlugS1rR0STv7rYBYcUjDZQ45pyVUvOSFfaRp4
Goals
Provide a user-friendly interface for metrics reporting by mdatagen tool
Currently mdatagen tool produces
generated_metrics.go
files that contain mostly definitions of the metrics taken frommetadata.yaml
files. Scraper authors have to add some amount of repetitive code to each of the scrapers to fill the metrics with data points and send them downstream. We want to reduce the amount of the repetitive code and provide scraper authors with a simple interface for reporting metrics that will be generated from metadata.yaml files.Ability to change the default metrics representation by applying user settings
We need a way to customize the default representation of the metrics generated by mdatagen based on user's config. Once we move metrics generation to the Metrics Builder generated by mdatagen, it'll be be possible to customize metrics based on user settings.
As the first step, we want to provide a way to enable or disable any metrics based on user config. This functionality should be encapsulated in the Metrics Builder generated by mdatagen, so scraper authors don't need to deal with user settings. This will also provide a way to introduce optional metrics which are disabled by default just by changing
metadata.yaml
properties.Progress
Metrics builder functionality:
Migrated scrapers:
Additional improvements
The text was updated successfully, but these errors were encountered: