[receiver/zookeeper] Migrate scraper to new experimental metrics builder #6522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
move-zookeeper-to-new-scraper
branch
from
c0b5526 to
4c7fa74
Compare
dmitryax
force-pushed
the
move-zookeeper-to-new-scraper
branch
5 times, most recently
from
3d57723 to
159063f
Compare
djaglowski
added
the
ready to merge
bogdandrutu
reviewed
Dec 9, 2021
receiver/zookeeperreceiver/internal/metadata/generated_metrics_v2.go
Outdated
Show resolved
Hide resolved
receiver/zookeeperreceiver/internal/metadata/generated_metrics_v2.go
Outdated
Show resolved
Hide resolved
bogdandrutu
reviewed
Dec 9, 2021
| } | ||
| } | ||
| if keepRM { | ||
| z.mb.Emit(ilm.Metrics()) | ||
| if ilm.Metrics().Len() > 0 { | ||
| rm.CopyTo(rms.AppendEmpty()) |
There was a problem hiding this comment.
Maybe followup, investigate if this can be "MoveTo" :)
dmitryax
force-pushed
the
move-zookeeper-to-new-scraper
branch
from
159063f to
4a04116
Compare
|
Now depends on the fix: #6683 UPD: PR merged, this one is rebased |
dmitryax
force-pushed
the
move-zookeeper-to-new-scraper
branch
from
4a04116 to
fb5ab1e
Compare
dmitryax
force-pushed
the
move-zookeeper-to-new-scraper
branch
from
fb5ab1e to
1f7d6e0
Compare
bogdandrutu
approved these changes
Dec 10, 2021
PaurushGarg
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Dec 11, 2021
PaurushGarg
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Dec 11, 2021
PaurushGarg
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Dec 14, 2021
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
Signed-off-by: Bogdan Drutu <[email protected]> Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Issue: open-telemetry/opentelemetry-collector#10904