-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/elasticsearch]: add metrics related to GET operations #14793
[receiver/elasticsearch]: add metrics related to GET operations #14793
Conversation
c852dee
to
2978638
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the general approach of adding a new metric here. The other metric is focused on the type of operations, whereas this new one is focused on the result of an operation.
571187c
to
9ee4a15
Compare
This seems outdated: |
9ee4a15
to
8809629
Compare
Rebased after one test file has been removed. |
8809629
to
138bfe4
Compare
The metrics are now disabled by default. |
…-telemetry#14793) feat: add metrics related to GET operations
…-telemetry#14793) feat: add metrics related to GET operations
Description:
New metrics have been added. However, I think that they're a bit troublesome to add. They are metrics that reflect how many GET operations ended up with success (
exists
), how many ended up with failure(missing
) and time spent on these operations.Currently (on main) only total sum of these two values is being sent as
elasticsearch.node.operations.*
metrics withget
attribute. This is the main reason why I think that adding them is not easy. I thought up of two solutions that wouldn't be breaking changes:get_exists
andget_missing
- it would not be a breaking change, but I feel that it doesn't look goodelasticsearch.node.operations.get.*
- it is not consistent with how other metrics are organised, but neither breaks anything. Might seem unintuitive, because then total count would beelasticsearch.node.operations.completed
, but total success count would beelasticsearch.node.operations.get.completed
.I implemented the second one, but I'm open for discussion. If we don't mind breaking changes, then we could for example implement the first one and remove the total count, because
exists + missing = total
.Link to tracking Issue: #14635
Testing:
Unit tests and integration tests.
Documentation:
Generated by
mdatagen
.