[cmd/mdatagen] Remove the old metadata generator #13374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
commented
Aug 15, 2022
| } | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
This file was replaced by metrics_v2.tmpl as is. no code changes
TylerHelmuth
approved these changes
Aug 15, 2022
All receivers were migrated to the new metrics builder. We can remove the old mdatagen tool and declare the new metrics builder as stable.
dmitryax
force-pushed
the
remove-old-mdatagen
branch
from
79882fa to
8221167
Compare
I don't see any other places that need updates |
bogdandrutu
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All receivers were migrated to the new metrics builder. We can remove the old mdatagen tool and declare the new metrics builder as stable.
Link to tracking Issue: open-telemetry/opentelemetry-collector#10904