Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics builder] Non-string support for enum attributes #16419

Closed
Tracked by #10904
dmitryax opened this issue Nov 22, 2022 · 8 comments
Closed
Tracked by #10904

[metrics builder] Non-string support for enum attributes #16419

dmitryax opened this issue Nov 22, 2022 · 8 comments
Labels
closed as inactive cmd/mdatagen mdatagen command enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Stale

Comments

@dmitryax
Copy link
Member

dmitryax commented Nov 22, 2022

Currently, only strings can be specified in attribute.enum field. We need a way to set different enum values when type is not a string. The type must be validated against the type field. Must be applicable to both metric attributes and resource attributes.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jan 23, 2023
@dmitryax dmitryax removed the Stale label Feb 3, 2023
@atoulme atoulme added cmd/mdatagen mdatagen command enhancement New feature or request labels Mar 12, 2023
@github-actions
Copy link
Contributor

Pinging code owners for cmd/mdatagen: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@abhide
Copy link
Member

abhide commented Mar 13, 2023

@dmitryax I would like to work on this issue. Can you please assign it to me?

@dmitryax
Copy link
Member Author

@abhide, thanks! Assigned

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 15, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2023
@dmitryax dmitryax reopened this Aug 10, 2023
@dmitryax dmitryax added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • issue: Github issue template generation code needs this to generate the corresponding labels.
  • cmd/mdatagen: @dmitryax

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 9, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive cmd/mdatagen mdatagen command enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Stale
Projects
None yet
Development

No branches or pull requests

3 participants