[datadogexporter] Fix missing resource attributes default mapping when resource_attributes_as_tags: false #6359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSerrania
force-pushed
the
kserrania/fix-resource-attributes-mapping
branch
2 times, most recently
from
dae79da to
87adc7c
Compare
…n resource_attributes_as_tags: false
KSerrania
force-pushed
the
kserrania/fix-resource-attributes-mapping
branch
from
87adc7c to
27e92a5
Compare
albertvaka
approved these changes
Nov 17, 2021
mx-psi
reviewed
Nov 17, 2021
mx-psi
approved these changes
Nov 17, 2021
| func newTranslator(t *testing.T, logger *zap.Logger) *Translator { | ||
| tr, err := New( | ||
| logger, | ||
| func newTranslator(t *testing.T, logger *zap.Logger, resourceAttributesAsTags, instrumentationLibraryMetadataAsTags bool) *Translator { |
There was a problem hiding this comment.
nit: maybe adding a options ...Options argument list instead is better to avoid having to change the function signature for every new thing that we want to test
mx-psi
approved these changes
Nov 17, 2021
8 tasks
KSerrania
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Nov 18, 2021
…rce_attributes_as_tags: false (#9946) Backport of open-telemetry/opentelemetry-collector-contrib#6359. Fixes the additional tags list not getting correctly set when `resource_attributes_as_tags: false` and `instrumentation_library_metadata_as_tags: false`. Adds unit tests.
zandrewitte
pushed a commit
to StackVista/stackstate-agent
that referenced
this pull request
Nov 17, 2022
…rce_attributes_as_tags: false (DataDog#9946) Backport of open-telemetry/opentelemetry-collector-contrib#6359. Fixes the additional tags list not getting correctly set when `resource_attributes_as_tags: false` and `instrumentation_library_metadata_as_tags: false`. Adds unit tests.
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
* [docs] update design.md doc Started looking at various documents under the `docs` directory that are somewhat outdatted. This PR updates the design document. * Apply suggestions from code review Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since #5431, when
resource_attributes_as_tags: falseandinstrumentation_library_metadata_as_tags: false(default config), the default resource attributes mapping done byattributes.TagsFromAttributeswouldn't be added to the metric tags.Link to tracking Issue: n/a, found during testing.
Testing: Added unit tests.
Documentation: n/a