Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadogexporter] Fix missing resource attributes default mapping when resource_attributes_as_tags: false #6359

Merged
merged 6 commits into from
Nov 17, 2021
Merged

[datadogexporter] Fix missing resource attributes default mapping when resource_attributes_as_tags: false #6359

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27e92a5
[datadogexporter] Fix missing resource attributes default mapping whe…
KSerrania Nov 17, 2021
752cb3e
Add unit tests
KSerrania Nov 17, 2021
e7fabab
Remove debug logs
KSerrania Nov 17, 2021
d83dc95
Variable renaming
KSerrania Nov 17, 2021
ca51916
Pass Options to newTranslator
KSerrania Nov 17, 2021
0ccb63a
Remove unneeded param from newSketchWithHostname
KSerrania Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions exporter/datadogexporter/internal/translator/metrics_translator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,8 @@ func (t *Translator) MapMetrics(ctx context.Context, md pdata.Metrics, consumer
var additionalTags []string
if t.cfg.InstrumentationLibraryMetadataAsTags {
additionalTags = append(attributeTags, instrumentationlibrary.TagsFromInstrumentationLibraryMetadata(ilm.InstrumentationLibrary())...)
} else {
additionalTags = attributeTags
mx-psi marked this conversation as resolved.
Show resolved Hide resolved
}

for k := 0; k < metricsArray.Len(); k++ {
Expand Down
Loading