[datadogexporter] Add option to send instrumentation library metadata tags with metrics #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mx-psi PTAL |
mx-psi
reviewed
Sep 24, 2021
exporter/datadogexporter/internal/instrumentationlibrary/metadata.go
Outdated
Show resolved
Hide resolved
KSerrania
force-pushed
the
kserrania/add-ilmetadata
branch
from
11987cb to
57a1e0d
Compare
mx-psi
reviewed
Sep 27, 2021
mx-psi
approved these changes
Sep 28, 2021
|
Looks good, although you need to fix the merge conflict |
|
This now conflicts with #5270 too, you will need to add a new |
mx-psi
approved these changes
Oct 6, 2021
5 tasks
KSerrania
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Oct 15, 2021
…tags with metrics (#9472) Backport of open-telemetry/opentelemetry-collector-contrib#5431 to the `pkg/otlp/model` go module.
zandrewitte
pushed a commit
to StackVista/stackstate-agent
that referenced
this pull request
Nov 17, 2022
…tags with metrics (DataDog#9472) Backport of open-telemetry/opentelemetry-collector-contrib#5431 to the `pkg/otlp/model` go module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds a new opt-in option,
instrumentation_library_metadata_as_tags, to add the instrumentation library name and version as tags on metrics sent by the exporter.Note: should the name or version tag still be added if the field is an empty string?
Link to tracking Issue: n/a
Testing: Added a unit test.
Documentation: Example file & inline code documentation.