Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadogexporter] Decouple translator and exporter configuration #5270

Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Sep 17, 2021

Description:

Refactor translator to use an independent configuration from the exporter configuration.

Link to tracking Issue: n/a

Testing: amended unit tests.

@mx-psi mx-psi force-pushed the mx-psi/decouple-translator-config branch 2 times, most recently from 2315d71 to bd50a25 Compare September 21, 2021 14:14
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi mx-psi force-pushed the mx-psi/decouple-translator-config branch from bd50a25 to 13d8a86 Compare September 23, 2021 09:32
@mx-psi mx-psi force-pushed the mx-psi/decouple-translator-config branch from 78f6d8e to 0880f77 Compare September 24, 2021 08:54
mx-psi added a commit to DataDog/datadog-agent that referenced this pull request Sep 27, 2021
* [exporter/datadogexporter] Copy main branch contents

* Decouple translator configuration from Collector configuration (open-telemetry/opentelemetry-collector-contrib#5270)

* Use a `Consumer` interface for decoupling from zorkian's package (open-telemetry/opentelemetry-collector-contrib#5315)

* Make tests pass
@mx-psi mx-psi marked this pull request as ready for review September 30, 2021 09:59
@mx-psi mx-psi requested review from a team and djaglowski September 30, 2021 09:59
@mx-psi mx-psi force-pushed the mx-psi/decouple-translator-config branch from 7c2dc02 to 077ae3f Compare September 30, 2021 10:30
@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Oct 4, 2021
@tigrannajaryan tigrannajaryan merged commit bf7ff95 into open-telemetry:main Oct 4, 2021
zandrewitte pushed a commit to StackVista/stackstate-agent that referenced this pull request Nov 17, 2022
* [exporter/datadogexporter] Copy main branch contents

* Decouple translator configuration from Collector configuration (open-telemetry/opentelemetry-collector-contrib#5270)

* Use a `Consumer` interface for decoupling from zorkian's package (open-telemetry/opentelemetry-collector-contrib#5315)

* Make tests pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants