-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datadogexporter] Decouple translator and exporter configuration #5270
Merged
tigrannajaryan
merged 4 commits into
open-telemetry:main
from
DataDog:mx-psi/decouple-translator-config
Oct 4, 2021
Merged
[exporter/datadogexporter] Decouple translator and exporter configuration #5270
tigrannajaryan
merged 4 commits into
open-telemetry:main
from
DataDog:mx-psi/decouple-translator-config
Oct 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/decouple-translator-config
branch
2 times, most recently
from
September 21, 2021 14:14
2315d71
to
bd50a25
Compare
KSerrania
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…lector configuration
mx-psi
force-pushed
the
mx-psi/decouple-translator-config
branch
from
September 23, 2021 09:32
bd50a25
to
13d8a86
Compare
mx-psi
force-pushed
the
mx-psi/decouple-translator-config
branch
from
September 24, 2021 08:54
78f6d8e
to
0880f77
Compare
mx-psi
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Sep 24, 2021
mx-psi
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Sep 27, 2021
* [exporter/datadogexporter] Copy main branch contents * Decouple translator configuration from Collector configuration (open-telemetry/opentelemetry-collector-contrib#5270) * Use a `Consumer` interface for decoupling from zorkian's package (open-telemetry/opentelemetry-collector-contrib#5315) * Make tests pass
This backports fixes from: - DataDog/datadog-agent@a258ba7, - DataDog/datadog-agent#9266 and - DataDog/datadog-agent#9273.
mx-psi
force-pushed
the
mx-psi/decouple-translator-config
branch
from
September 30, 2021 10:30
7c2dc02
to
077ae3f
Compare
KSerrania
approved these changes
Oct 4, 2021
mx-psi
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Oct 4, 2021
tigrannajaryan
approved these changes
Oct 4, 2021
This was referenced Oct 21, 2021
zandrewitte
pushed a commit
to StackVista/stackstate-agent
that referenced
this pull request
Nov 17, 2022
* [exporter/datadogexporter] Copy main branch contents * Decouple translator configuration from Collector configuration (open-telemetry/opentelemetry-collector-contrib#5270) * Use a `Consumer` interface for decoupling from zorkian's package (open-telemetry/opentelemetry-collector-contrib#5315) * Make tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor translator to use an independent configuration from the exporter configuration.
Link to tracking Issue: n/a
Testing: amended unit tests.