[pkg/otlp] Fix missing resource attributes default mapping when resource_attributes_as_tags: false #9946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Backport of open-telemetry/opentelemetry-collector-contrib#6359.
Fixes the additional tags list not getting correctly set when
resource_attributes_as_tags: false
andinstrumentation_library_metadata_as_tags: false
.Adds unit tests.
Motivation
Since #9472, when
resource_attributes_as_tags: false
andinstrumentation_library_metadata_as_tags: false
(default config), the default resource attributes mapping done byattributes.TagsFromAttributes
wouldn't be added to the metric tags.Describe how to test/QA your changes
Run the Agent with the OTLP pipeline, with the default settings. Check that the resource attributes that should be converted by default (eg.
development.environment
) are indeed converted into their corresponding tags.Reviewer's Checklist
Triage
milestone is set.team/..
label has been applied, if known.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.need-change/operator
andneed-change/helm
labels have been applied.