-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for utils/urlMatchers.ts #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
@ozgursar thank you for this PR! it would be great to follow the last check remained in action by adding this: This will help us to auto-close the issue when we merge this PR. For further details you can check the GitHub docs. |
I could't get it pass the last check |
fixed in #147 |
I agree Co-authored-by: Brian Douglas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the other "abcd" tests to "google.com"
β¦ensions into add-tests-for-utils
## [1.3.1-beta.2](v1.3.1-beta.1...v1.3.1-beta.2) (2023-05-27) ### β Tests * add tests for utils/urlMatchers.ts ([#143](#143)) ([26702e6](26702e6))
π This PR is included in version 1.3.1-beta.2 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.4.0](v1.3.0...v1.4.0) (2023-06-03) ### β Tests * add tests for checkAuth.ts ([#149](#149)) ([3a79fac](3a79fac)) * add tests for utils/urlMatchers.ts ([#143](#143)) ([26702e6](26702e6)) ### π Bug Fixes * Post a highlight ([#101](#101)) ([e3b7051](e3b7051)) * remove auto-take message from triage.yml ([258a828](258a828)) * rename triage.yml ([3b9a14b](3b9a14b)) * undefined config during build ([#158](#158)) ([c986086](c986086)) ### π Features * latest highlights ([#154](#154)) ([0ccd0e7](0ccd0e7)) * uses username on highlight instead of full name ([#162](#162)) ([801fe5a](801fe5a))
π This PR is included in version 1.4.0 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.3.1-beta.2](open-sauced/ai@v1.3.1-beta.1...v1.3.1-beta.2) (2023-05-27) ### β Tests * add tests for utils/urlMatchers.ts ([#143](open-sauced/ai#143)) ([26702e6](open-sauced/ai@26702e6))
## [1.4.0](open-sauced/ai@v1.3.0...v1.4.0) (2023-06-03) ### β Tests * add tests for checkAuth.ts ([#149](open-sauced/ai#149)) ([3a79fac](open-sauced/ai@3a79fac)) * add tests for utils/urlMatchers.ts ([#143](open-sauced/ai#143)) ([26702e6](open-sauced/ai@26702e6)) ### π Bug Fixes * Post a highlight ([#101](open-sauced/ai#101)) ([e3b7051](open-sauced/ai@e3b7051)) * remove auto-take message from triage.yml ([258a828](open-sauced/ai@258a828)) * rename triage.yml ([3b9a14b](open-sauced/ai@3b9a14b)) * undefined config during build ([#158](open-sauced/ai#158)) ([c986086](open-sauced/ai@c986086)) ### π Features * latest highlights ([#154](open-sauced/ai#154)) ([0ccd0e7](open-sauced/ai@0ccd0e7)) * uses username on highlight instead of full name ([#162](open-sauced/ai#162)) ([801fe5a](open-sauced/ai@801fe5a))
What type of PR is this? (check all applicable)
Description
This PR adds the tests for #142
Related Tickets & Documents
fix #142
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?