test: add tests for checkAuth.ts #149
Conversation
|
@diivi, the function signature has become complicated. We don't really need to tersely parameterize a relatively simple function for the sake of adding unit tests to it. |
|
imo it's still pretty simple to understand with the naming, and these side effect inducing functions should definitely be tested (no other way to test them). If it doesn't get called frequently, it shouldn't matter as much. |
|
About the tests. We are just mocking values in the tests, which effectively just checks if the conditional statements work. I don't think the test justifies changing the function signature to parameterize all the utility functions used within. Which also means that we can't just import and use |
That's how tests work everywhere😅.
It actually makes it purer and importing some extra functions does less harm than using foreign side effect inducing APIs. Also without importing those functions this can't be tested, ref test parameterization. If we need more coverage, especially with these files we need to parameterize functions. |
|
Also, the second signature is more of a "signature" since it tells you all the dependencies of the function. |
That's the only thing we can test, by mocking external APIs. It's just a check for future changes as you mentioned, if something changes in the checkAuth function, it needs to pass the previous tests so devs know atleast the flow is correct, and add/edit tests for any change that they made. |
|
That sounds right. 👍👍. |
## [1.3.1-beta.3](v1.3.1-beta.2...v1.3.1-beta.3) (2023-05-29) ### ✅ Tests * add tests for checkAuth.ts ([#149](#149)) ([3a79fac](3a79fac))
|
🎉 This PR is included in version 1.3.1-beta.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.4.0](v1.3.0...v1.4.0) (2023-06-03) ### ✅ Tests * add tests for checkAuth.ts ([#149](#149)) ([3a79fac](3a79fac)) * add tests for utils/urlMatchers.ts ([#143](#143)) ([26702e6](26702e6)) ### 🐛 Bug Fixes * Post a highlight ([#101](#101)) ([e3b7051](e3b7051)) * remove auto-take message from triage.yml ([258a828](258a828)) * rename triage.yml ([3b9a14b](3b9a14b)) * undefined config during build ([#158](#158)) ([c986086](c986086)) ### 🍕 Features * latest highlights ([#154](#154)) ([0ccd0e7](0ccd0e7)) * uses username on highlight instead of full name ([#162](#162)) ([801fe5a](801fe5a))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.3.1-beta.3](open-sauced/ai@v1.3.1-beta.2...v1.3.1-beta.3) (2023-05-29) ### ✅ Tests * add tests for checkAuth.ts ([#149](open-sauced/ai#149)) ([3a79fac](open-sauced/ai@3a79fac))
## [1.4.0](open-sauced/ai@v1.3.0...v1.4.0) (2023-06-03) ### ✅ Tests * add tests for checkAuth.ts ([#149](open-sauced/ai#149)) ([3a79fac](open-sauced/ai@3a79fac)) * add tests for utils/urlMatchers.ts ([#143](open-sauced/ai#143)) ([26702e6](open-sauced/ai@26702e6)) ### 🐛 Bug Fixes * Post a highlight ([#101](open-sauced/ai#101)) ([e3b7051](open-sauced/ai@e3b7051)) * remove auto-take message from triage.yml ([258a828](open-sauced/ai@258a828)) * rename triage.yml ([3b9a14b](open-sauced/ai@3b9a14b)) * undefined config during build ([#158](open-sauced/ai#158)) ([c986086](open-sauced/ai@c986086)) ### 🍕 Features * latest highlights ([#154](open-sauced/ai#154)) ([0ccd0e7](open-sauced/ai@0ccd0e7)) * uses username on highlight instead of full name ([#162](open-sauced/ai#162)) ([801fe5a](open-sauced/ai@801fe5a))
Adds tests for
checkAuthentication.ts@Anush008 can you check if everything still works? I mean your login and logout logic (and related stuff), I was able to log in and log out, but maybe I missed something.
I had to refactor checkAuthentication() to make it more pure and testable. Will cover more lines soon.