-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: latest highlights #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
@bdougie I moved that PR here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, did a little nitpicking.
the design could be improved later,
@@ -17,7 +17,7 @@ export const OPEN_SAUCED_USER_INSIGHTS_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/u | |||
export const OPEN_SAUCED_AI_PR_DESCRIPTION_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/prs/description/generate`; | |||
export const OPEN_SAUCED_USER_HIGHLIGHTS_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/user/highlights`; | |||
export const OPEN_SAUCED_AI_CODE_REFACTOR_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/prs/suggestion/generate`; | |||
|
|||
export const OPEN_SAUCED_HIGHLIGHTS_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/highlights/list`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const OPEN_SAUCED_HIGHLIGHTS_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/highlights/list`; | |
export const OPEN_SAUCED_HIGHLIGHTS_LIST_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/highlights/list`; |
to match the naming convention above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good minimal viable feature. Once the nits are addressed, we can merge this.
Great job @BekahHW, appreciate the contribution.
This reverts commit 8e8bb0b.
Going to merge as is and focus on the comments here #159 |
## [1.4.0-beta.1](v1.3.1-beta.5...v1.4.0-beta.1) (2023-06-03) ### π Features * latest highlights ([#154](#154)) ([0ccd0e7](0ccd0e7))
π This PR is included in version 1.4.0-beta.1 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.4.0](v1.3.0...v1.4.0) (2023-06-03) ### β Tests * add tests for checkAuth.ts ([#149](#149)) ([3a79fac](3a79fac)) * add tests for utils/urlMatchers.ts ([#143](#143)) ([26702e6](26702e6)) ### π Bug Fixes * Post a highlight ([#101](#101)) ([e3b7051](e3b7051)) * remove auto-take message from triage.yml ([258a828](258a828)) * rename triage.yml ([3b9a14b](3b9a14b)) * undefined config during build ([#158](#158)) ([c986086](c986086)) ### π Features * latest highlights ([#154](#154)) ([0ccd0e7](0ccd0e7)) * uses username on highlight instead of full name ([#162](#162)) ([801fe5a](801fe5a))
π This PR is included in version 1.4.0 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.4.0-beta.1](open-sauced/ai@v1.3.1-beta.5...v1.4.0-beta.1) (2023-06-03) ### π Features * latest highlights ([#154](open-sauced/ai#154)) ([0ccd0e7](open-sauced/ai@0ccd0e7))
## [1.4.0](open-sauced/ai@v1.3.0...v1.4.0) (2023-06-03) ### β Tests * add tests for checkAuth.ts ([#149](open-sauced/ai#149)) ([3a79fac](open-sauced/ai@3a79fac)) * add tests for utils/urlMatchers.ts ([#143](open-sauced/ai#143)) ([26702e6](open-sauced/ai@26702e6)) ### π Bug Fixes * Post a highlight ([#101](open-sauced/ai#101)) ([e3b7051](open-sauced/ai@e3b7051)) * remove auto-take message from triage.yml ([258a828](open-sauced/ai@258a828)) * rename triage.yml ([3b9a14b](open-sauced/ai@3b9a14b)) * undefined config during build ([#158](open-sauced/ai#158)) ([c986086](open-sauced/ai@c986086)) ### π Features * latest highlights ([#154](open-sauced/ai#154)) ([0ccd0e7](open-sauced/ai@0ccd0e7)) * uses username on highlight instead of full name ([#162](open-sauced/ai#162)) ([801fe5a](open-sauced/ai@801fe5a))
What type of PR is this? (check all applicable)
Description
This PR adds a new constant for the highlights endpoint and fetches the latest highlight from the API to display on the home page. It also adds pagination to the highlights section and allows users to navigate through the highlights. Additionally, it includes a new function to fetch highlights from the API.
Generated using OpenSauced.
Related Tickets & Documents
closes #78
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2023-06-02.at.4.56.57.PM.mov
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
#159
[optional] What gif best describes this PR or how it makes you feel?