Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: implementing utils/urlMatchers.ts tests #142

Closed
1 of 2 tasks
Tracked by #140
a0m0rajab opened this issue May 27, 2023 · 8 comments · Fixed by #143
Closed
1 of 2 tasks
Tracked by #140

Feature: implementing utils/urlMatchers.ts tests #142

a0m0rajab opened this issue May 27, 2023 · 8 comments · Fixed by #143

Comments

@a0m0rajab
Copy link
Contributor

Type of feature

✅ Test

Current behavior

Right now we do not have a full implementation of these function tests we will to work on them.

Suggested solution

No response

Additional context

Related to: #140

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@a0m0rajab a0m0rajab mentioned this issue May 27, 2023
6 tasks
@a0m0rajab
Copy link
Contributor Author

a0m0rajab commented May 27, 2023

@ozgursar can you run .take here?

@ozgursar
Copy link
Contributor

thank you @a0m0rajab. I will create the PR now

@github-actions
Copy link

The auto-take issues workflow is not enabled here, we can only assign issues to @open-sauced/triage, @open-sauced/committers, @open-sauced/maintainers in this repo for now. We suggest folks not on the team open issues and take a look at the Bugs or Papercuts. If you would like to find good first issues, please check out the companion project to this, open-sauced/hot.

@ozgursar
Copy link
Contributor

.take

@a0m0rajab a0m0rajab assigned ozgursar and unassigned a0m0rajab May 27, 2023
@github-actions
Copy link

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.3.1-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@a0m0rajab
Copy link
Contributor Author

a0m0rajab commented May 27, 2023

For reference, this was partially in #139

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants