Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for utils/urlMatchers.ts #143

Merged
merged 4 commits into from
May 27, 2023

Conversation

ozgursar
Copy link
Contributor

@ozgursar ozgursar commented May 27, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR adds the tests for #142

Related Tickets & Documents

fix #142

Mobile & Desktop Screenshots/Recordings

t

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@ozgursar ozgursar changed the title feature: add tests for urlMatchers test: add tests for urlMatchers May 27, 2023
@ozgursar ozgursar changed the title test: add tests for urlMatchers test: add tests for utils/urlMatchers.ts May 27, 2023
@a0m0rajab
Copy link
Contributor

@ozgursar thank you for this PR! it would be great to follow the last check remained in action by adding this:
fix #143 in your main comment.

This will help us to auto-close the issue when we merge this PR.

For further details you can check the GitHub docs.

@a0m0rajab a0m0rajab mentioned this pull request May 27, 2023
2 tasks
@ozgursar
Copy link
Contributor Author

@ozgursar thank you for this PR! it would be great to follow the last check remained in action by adding this: fix #143 in your main comment.

This will help us to auto-close the issue when we merge this PR.

For further details you can check the GitHub docs.

I could't get it pass the last check

@a0m0rajab
Copy link
Contributor

Thank you for your work πŸ‘ , there is an issue from our side in the last check, I opened an issue for that to check!

I will not be able to review this right now, will leave it to @Anush008 and @diivi

@bdougie
Copy link
Member

bdougie commented May 27, 2023

Thank you for your work πŸ‘ , there is an issue from our side in the last check, I opened an issue for that to check!

fixed in #147

I agree

Co-authored-by: Brian Douglas <[email protected]>
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the other "abcd" tests to "google.com"

@bdougie bdougie merged commit 26702e6 into open-sauced:beta May 27, 2023
github-actions bot pushed a commit that referenced this pull request May 27, 2023
## [1.3.1-beta.2](v1.3.1-beta.1...v1.3.1-beta.2) (2023-05-27)

### βœ… Tests

* add tests for utils/urlMatchers.ts ([#143](#143)) ([26702e6](26702e6))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.3.1-beta.2 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Jun 3, 2023
## [1.4.0](v1.3.0...v1.4.0) (2023-06-03)

### βœ… Tests

* add tests for checkAuth.ts ([#149](#149)) ([3a79fac](3a79fac))
* add tests for utils/urlMatchers.ts ([#143](#143)) ([26702e6](26702e6))

### πŸ› Bug Fixes

* Post a highlight ([#101](#101)) ([e3b7051](e3b7051))
* remove auto-take message from triage.yml ([258a828](258a828))
* rename triage.yml ([3b9a14b](3b9a14b))
* undefined config during build ([#158](#158)) ([c986086](c986086))

### πŸ• Features

* latest highlights ([#154](#154)) ([0ccd0e7](0ccd0e7))
* uses username on highlight instead of full name ([#162](#162)) ([801fe5a](801fe5a))
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

πŸŽ‰ This PR is included in version 1.4.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.3.1-beta.2](open-sauced/ai@v1.3.1-beta.1...v1.3.1-beta.2) (2023-05-27)

### βœ… Tests

* add tests for utils/urlMatchers.ts ([#143](open-sauced/ai#143)) ([26702e6](open-sauced/ai@26702e6))
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.4.0](open-sauced/ai@v1.3.0...v1.4.0) (2023-06-03)

### βœ… Tests

* add tests for checkAuth.ts ([#149](open-sauced/ai#149)) ([3a79fac](open-sauced/ai@3a79fac))
* add tests for utils/urlMatchers.ts ([#143](open-sauced/ai#143)) ([26702e6](open-sauced/ai@26702e6))

### πŸ› Bug Fixes

* Post a highlight ([#101](open-sauced/ai#101)) ([e3b7051](open-sauced/ai@e3b7051))
* remove auto-take message from triage.yml ([258a828](open-sauced/ai@258a828))
* rename triage.yml ([3b9a14b](open-sauced/ai@3b9a14b))
* undefined config during build ([#158](open-sauced/ai#158)) ([c986086](open-sauced/ai@c986086))

### πŸ• Features

* latest highlights ([#154](open-sauced/ai#154)) ([0ccd0e7](open-sauced/ai@0ccd0e7))
* uses username on highlight instead of full name ([#162](open-sauced/ai#162)) ([801fe5a](open-sauced/ai@801fe5a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: implementing utils/urlMatchers.ts tests
3 participants